Some changes on sign cmd and config#298
Merged
ligangty merged 1 commit intoCommonjava:mainfrom May 26, 2025
Merged
Conversation
yma955
reviewed
May 26, 2025
| radas_config: Dict = data.get("radas", None) | ||
| if radas_config: | ||
| self.__radas_config__ = RadasConfig(radas_config) | ||
| self.__radas_config = RadasConfig(radas_config) |
Member
There was a problem hiding this comment.
@ligangty If no Optional to initialize the __radas_config, I'm afraid it will report AttributeError: CharonConfig object has no attribute radas_config when the method get_radas_config is called without radas_config there, we have some places that call this method.
Member
Author
There was a problem hiding this comment.
Sounds reasonable. I'll correct it. Thanks
Pull Request Test Coverage Report for Build 15249017201Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.